Add CONTRIBUTING, CI, and fix maps icons/tiles#673
Open
Nishant141 wants to merge 1 commit intodata-8:masterfrom
Open
Add CONTRIBUTING, CI, and fix maps icons/tiles#673Nishant141 wants to merge 1 commit intodata-8:masterfrom
Nishant141 wants to merge 1 commit intodata-8:masterfrom
Conversation
Member
|
Thanks for all the suggested changes! Fixes to tiles issues seems valuable. Generally I'd prefer to have logically different changes split into separate pull requests: e.g., one for changes to workflow, one for changes to documentation about contributing, one for maps/tiles. Can you split this up? I don't understand the benefit of this new workflow file over what we already have in .github/workflows/run_tests.yml; can you help me understand that? Also isn't most everything in CONTRIBUTING already covered in DEVELOPERS.md -- is there value to that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CONTRIBUTING.md and CI workflow. Fixes folium tile attribution error for string tiles and normalizes BeautifyIcon option keys so icons expose
textColor. Runs tests locally.